fix: Unexpected Safari-specific event init options #1964
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
inputfiles/removedTypes.jsonc
Outdated
| "FetchEventInit": { | ||
| "members": { | ||
| "member": { | ||
| "replacesClientId": null // Removed from all browsers |
There was a problem hiding this comment.
Not sure it's removed or simply not implemented. Unless there's clues let's say not implemented. And please write the confirmed date as things change.
inputfiles/removedTypes.jsonc
Outdated
| } | ||
| } | ||
| }, | ||
| "FetchEventInit": { |
There was a problem hiding this comment.
This file tries to make things alphabetically ordered, please move this above. Same for the event init.
|
Done @saschanaz |
inputfiles/removedTypes.jsonc
Outdated
| "FetchEventInit": { | ||
| "members": { | ||
| "member": { | ||
| "replacesClientId": null // Not implemented |
There was a problem hiding this comment.
Can you add dates as line 355 does for example? Same below.
|
Hello @saschanaz |
There was a problem hiding this comment.
@jakebailey or @sandersn for merging, because of broken workflow...
Co-authored-by: Kagami Sascha Rosylight <[email protected]>
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
fixes #1689